Conversation
|
Please review @mayspc @codegino |
codegino
left a comment
codegino
left a comment
There was a problem hiding this comment.
I tried on my local and didn't see any obvious issues. Will wait for others to double confirm.
There was a problem hiding this comment.
This PR currently introduces a library clash
src/components/ui follows different conventions. and there are 2 files with the same name but different capitalization with different contents
Dialog.tsx (existing)
dialog.tsx (this pr)
either we:
- move this into its own folder
- move the existing components into its own folder
- use the existing components
- use the new shadcn components
eitherway, this will set the direction of the repo forward.
Let's postpone this until after the Design Meeting tomorrow.
Haven't really noticed this. I think it was caused by shad/cn, then another member creating that same component afterwards |
- Removed axios dependency from package.json. - Updated useMailerApi to use the fetch API instead of axios for making API calls. - Adjusted error handling and response parsing to accommodate the new fetch implementation.
- Add user friendly error
IamIsthill
force-pushed
the
feat/reporting
branch
from
33d7816 to
17489d9
Compare
|
@mayspc |
|
Hi! Let's stick to using the existing deisgn system for now, shadcn is currently causing conflicts with the files (specifically Dialog.tsx) |
angelofallars
added
enhancement
|
Stale pull request message |
4 participants
#207